> On Jan. 18, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote: > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcPreparedStatement.java, > > line 60 > > <https://reviews.apache.org/r/41630/diff/3/?file=1196923#file1196923line60> > > > > I dont see prepare on lens-server getting called anywhere? Am i missing > > something?
Hi, I am not able to use lens-server prepare as the server api does not accept perametrised query. and in case of saved query it needs to be aware of the data type of parameter at the time of prepare. while in case of jdbc driver we will be validating the parameter just before execution. while prepare there is no information about paremeters. so all the parameter resolution i am doing on client driver side and then calling the execute api. - piyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41630/#review114942 ----------------------------------------------------------- On Jan. 14, 2016, 3:12 p.m., piyush mukati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41630/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 3:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-897 > https://issues.apache.org/jira/browse/LENS-897 > > > Repository: lens > > > Description > ------- > > support for prepared query on lens client jdbc > > > Diffs > ----- > > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcConnection.java > 9ad31ee > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java > 056a0b2 > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcPreparedStatement.java > PRE-CREATION > > lens-client/src/test/java/org/apache/lens/jdbc/LensJdbcPreparedStatementTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41630/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.014 > s] > [INFO] Lens ............................................... SUCCESS [ 6.244 > s] > [INFO] Lens API ........................................... SUCCESS [ 24.663 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 29.026 > s] > [INFO] Lens Cube .......................................... SUCCESS [16:02 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 18.122 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 13.831 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [03:18 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 38.782 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 17.919 > s] > [INFO] Lens Server ........................................ SUCCESS [18:13 > min] > [INFO] Lens client ........................................ SUCCESS [ 46.207 > s] > [INFO] Lens CLI ........................................... SUCCESS [01:15 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.106 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.150 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 13.618 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:02 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.174 > s] > [INFO] Lens Regression .................................... SUCCESS [ 15.401 > s] > [INFO] Lens UI ............................................ SUCCESS [ 5.881 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 45:01 min > [INFO] Finished at: 2015-12-22T12:39:14+05:30 > [INFO] Final Memory: 131M/842M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > piyush mukati > >
