-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42707/#review116044
-----------------------------------------------------------




lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
<https://reviews.apache.org/r/42707/#comment177058>

    The comment is not valid now?


- Rajat Khandelwal


On Jan. 25, 2016, 11:34 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42707/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 11:34 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-927
>     https://issues.apache.org/jira/browse/LENS-927
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> The failure is because the JoinTree construction is picking the alias from 
> query, which is not required. Removing the same, fixed the failure.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
> acc9d5c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 
> 197847c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  d7707a9 
> 
> Diff: https://reviews.apache.org/r/42707/diff/
> 
> 
> Testing
> -------
> 
> All cube tests passed. Running full suite.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Reply via email to