----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42909/#review116766 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/APIResult.java (line 38) <https://reviews.apache.org/r/42909/#comment177847> Removal necessary? lens-api/src/main/java/org/apache/lens/api/Priority.java (line 36) <https://reviews.apache.org/r/42909/#comment177848> Don't we require `@XmlEnumValue("HIGH")` etc on individual values? lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java (line 30) <https://reviews.apache.org/r/42909/#comment177849> Same question as Priorities lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java (line 70) <https://reviews.apache.org/r/42909/#comment177850> Isn't there a way to specify the adapter once, instead of in every class? Something like http://stackoverflow.com/questions/6857166/jaxb-isnt-it-possible-to-use-an-xmladapter-without-xmljavatypeadapter lens-api/src/main/resources/cube-0.1.xsd (line 228) <https://reviews.apache.org/r/42909/#comment177851> seems a typo. lens-api/src/main/resources/cube-0.1.xsd (line 692) <https://reviews.apache.org/r/42909/#comment177852> Seems there are multiple typos. lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java (lines 35 - 37) <https://reviews.apache.org/r/42909/#comment177853> Shouldn't happen. Is it happening in any test case? lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (lines 755 - 764) <https://reviews.apache.org/r/42909/#comment177854> +1 lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (lines 261 - 280) <https://reviews.apache.org/r/42909/#comment177855> Typos here too? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (lines 795 - 810) <https://reviews.apache.org/r/42909/#comment177856> +1 lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (lines 1242 - 1243) <https://reviews.apache.org/r/42909/#comment177857> Changing the API? lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java (lines 49 - 50) <https://reviews.apache.org/r/42909/#comment177858> We should probably create a Base class of all `App` classes and add common classes there. lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 90) <https://reviews.apache.org/r/42909/#comment177860> Has that always been a bug? :o lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 257) <https://reviews.apache.org/r/42909/#comment177861> static? pom.xml (lines 74 - 75) <https://reviews.apache.org/r/42909/#comment177845> +1 pom.xml (lines 966 - 968) <https://reviews.apache.org/r/42909/#comment177846> could probably look for other possible exclusins - Rajat Khandelwal On Jan. 28, 2016, 6:10 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42909/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 6:10 p.m.) > > > Review request for lens. > > > Bugs: LENS-920 > https://issues.apache.org/jira/browse/LENS-920 > > > Repository: lens > > > Description > ------- > > Changes include : > - Moving to latest jersey, grizzly and jaxb versions > - Enable Moxy json features explicitly > - Fixing a bug in LensJerseyTest for starting tests on random port > - Annotate all enum classes with @XmlEnum > - Write JAXB adapter for UUID > - In Json the name of the field as "type" is reserved. Had to change all the > occurrances. > - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult> > - Update all tests to run against both XML and JSON marshalling/unmarshalling > - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed > TestMetastoreService wrt the same. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d > lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6 > lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6 > lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d > lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d > lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184 > lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java > 756287e > > lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java > 28d9710 > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e > lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java > d0c21a7 > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > aa4dc13 > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > c124a38 > lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c > lens-api/src/main/resources/cube-0.1.xsd d195b08 > lens-client/pom.xml 5f2f3a9 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 30a7e2c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > c64a3dd > > lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java > 1bb65ca > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > fc67df1 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 70323d3 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java > 520c698 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > fb937c6 > lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java > 9db034a > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > bb4cfd2 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java > 5c247be > lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java > a499968 > > lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java > faaf172 > lens-server/src/main/resources/lensserver-default.xml cac641a > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 8f52ddd > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > 94dd394 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 75f21e1 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 877200f > > lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java > 5301162 > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 4b25fd0 > lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java > 0400519 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 925fc86 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java > 85580da > > lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java > 515ac13 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 6f8886c > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > ab42a3d > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 4ac42b2 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 3facded > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > 30d1e34 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 3055ce5 > pom.xml 746204e > > Diff: https://reviews.apache.org/r/42909/diff/ > > > Testing > ------- > > All server tests are passing. > Pending: > Client tests > Updating examples > > > Thanks, > > Amareshwari Sriramadasu > >
