-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42653/#review116893
-----------------------------------------------------------




lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java (line 202)
<https://reviews.apache.org/r/42653/#comment177990>

    Should we remove the catch block ?


- Amareshwari Sriramadasu


On Jan. 28, 2016, 8:30 p.m., Deepak Barr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42653/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 8:30 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-928
>     https://issues.apache.org/jira/browse/LENS-928
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a null check to prevent NPE if the query is purged to DB.
> 
> 
> Diffs
> -----
> 
>   lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 
> d166e43 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2dff9af 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 494bce5 
> 
> Diff: https://reviews.apache.org/r/42653/diff/
> 
> 
> Testing
> -------
> 
> Yes. 
> Ran "mvn clean install" successfully.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Reply via email to