----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43243/#review117988 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On Feb. 5, 2016, 1:31 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43243/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 1:31 p.m.) > > > Review request for lens. > > > Bugs: LENS-946 > https://issues.apache.org/jira/browse/LENS-946 > > > Repository: lens > > > Description > ------- > > The issue was because the fact timerange clauses are replacing where AST in > all queries, but those clauses need to run through expression rewrite and > denormalization rewrite. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 4faebe1 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > ebf8875 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 0997f37 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > f2dc2e5 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > fa81831 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 9f16c5a > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 100d7c9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 8aab777 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > e569fb1 > > Diff: https://reviews.apache.org/r/43243/diff/ > > > Testing > ------- > > All cube tests passed. Running full test suite. > > > Thanks, > > Amareshwari Sriramadasu > >
