----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43086/#review118999 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 931) <https://reviews.apache.org/r/43086/#comment180299> Can you put skippedParts.size() in the log statement? Will be useful. lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java (lines 1699 - 1701) <https://reviews.apache.org/r/43086/#comment180300> Can you do set property directly in StorageTableDesc, before client.createCubeFactTable lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java (line 1706) <https://reviews.apache.org/r/43086/#comment180301> Are the partitions getting added which are 15 days olders? Then why are they not getting registered? lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java (line 2156) <https://reviews.apache.org/r/43086/#comment180302> Whats the time partition spec here? - Amareshwari Sriramadasu On Feb. 11, 2016, 6:12 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43086/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 6:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-932 > https://issues.apache.org/jira/browse/LENS-932 > > > Repository: lens > > > Description > ------- > > Changes to exclude partitions falling before fact absolute start time and > after next calendar date while registering. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 8969d1f > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 0c4871c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 4bc3f0a > > Diff: https://reviews.apache.org/r/43086/diff/ > > > Testing > ------- > > Added unit test. mvn clean install runs fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.153s] > [INFO] Lens .............................................. SUCCESS [3.222s] > [INFO] Lens API .......................................... SUCCESS [24.245s] > [INFO] Lens API for server and extensions ................ SUCCESS [24.086s] > [INFO] Lens Cube ......................................... SUCCESS > [11:35.288s] > [INFO] Lens DB storage ................................... SUCCESS [19.336s] > [INFO] Lens Query Library ................................ SUCCESS [15.747s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:51.274s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.827s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.644s] > [INFO] Lens Server ....................................... SUCCESS > [10:03.339s] > [INFO] Lens client ....................................... SUCCESS [36.487s] > [INFO] Lens CLI .......................................... SUCCESS [57.087s] > [INFO] Lens Examples ..................................... SUCCESS [10.920s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.706s] > [INFO] Lens Distribution ................................. SUCCESS [8.756s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:41.518s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.130s] > [INFO] Lens Regression ................................... SUCCESS [14.347s] > [INFO] Lens UI ........................................... SUCCESS [30.450s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 31:15.500s > [INFO] Finished at: Tue Feb 02 13:22:32 UTC 2016 > [INFO] Final Memory: 181M/1136M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
