> On Feb. 17, 2016, 7:38 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, lines > > 117-118 > > <https://reviews.apache.org/r/43600/diff/2/?file=1251715#file1251715line117> > > > > BITWISXOR belongs here?
xor is commutative, hence it can be kept here. > On Feb. 17, 2016, 7:38 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 417 > > <https://reviews.apache.org/r/43600/diff/2/?file=1251715#file1251715line417> > > > > I feel, this change may break test cases outside lens-cube module also. > > Any chnages to test cases outside of lens-cube ? Yes. Still figuring them out one by one. seeing need for changes in columnar sql rewriter. Will update all and update the testing done section once all done. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43600/#review119398 ----------------------------------------------------------- On Feb. 16, 2016, 8 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43600/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 8 p.m.) > > > Review request for lens. > > > Bugs: LENS-960 > https://issues.apache.org/jira/browse/LENS-960 > > > Repository: lens > > > Description > ------- > > Current scenario: > {noformat} > toString(parse("a or b or c or d")) == "(a or (b or (c or (d))))" > {noformat} > > Proposal is to remove the excessive nested braces. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > fdef3f1336534904bddaf430240d9c8e163d66ee > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 1d275589f43572a82b1fdb12a6606cc441b2ee37 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 45b43348c472778af6a118ec38982ee13ab33cf6 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java > 669a8e94d312bf58a2e559a935435da6f7d972c9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 4afd4037e4c969796a0c7a25cd32438a7d4e7b8f > > Diff: https://reviews.apache.org/r/43600/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
