----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43649/#review119443 -----------------------------------------------------------
pom.xml (line 1615) <https://reviews.apache.org/r/43649/#comment180814> uncomment. lens-driver-druid/src/main/java/com/apache/lens/driver/druid/ASTTraverserForDruid.java (lines 93 - 94) <https://reviews.apache.org/r/43649/#comment180960> All the `Helper.` methods can have wider usages, and can be moved to `HQLParser` lens-driver-druid/src/main/java/com/apache/lens/driver/druid/ASTTraverserForDruid.java (line 325) <https://reviews.apache.org/r/43649/#comment181179> Don't see the point of creating an encapsulating class. All the static methods can reside in the same class itself. lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidDriver.java (lines 134 - 149) <https://reviews.apache.org/r/43649/#comment181183> extract the string constant out lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidDriver.java (line 154) <https://reviews.apache.org/r/43649/#comment181184> debug log lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidDriver.java (lines 227 - 238) <https://reviews.apache.org/r/43649/#comment181187> should this code be in `createResultSet`? Please take a look at `AbstractLensDriver#fetchResultSet` lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/Aggregators.java (line 26) <https://reviews.apache.org/r/43649/#comment181205> rename to `Aggregator` ref: http://stackoverflow.com/questions/15755955/naming-of-enums-in-java-singular-or-plural lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/Aggregators.java (line 27) <https://reviews.apache.org/r/43649/#comment181204> make enum names in `PASCAL_CASE` lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/Aggregators.java (lines 56 - 64) <https://reviews.apache.org/r/43649/#comment181203> Keeping enum instances in a map against their names would be using extra memory for no good reason. `getFor` can be implemented without this too: ``` getFor(String s): return Aggregators.valueOf(s) ``` lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/LogicalOperators.java (line 31) <https://reviews.apache.org/r/43649/#comment181206> rename to `LogicalOperator` and make instances `PASCAL_CASE` lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/LogicalOperators.java (lines 55 - 68) <https://reviews.apache.org/r/43649/#comment181207> remove extra map lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/having/HavingLogicalOperators.java (line 31) <https://reviews.apache.org/r/43649/#comment181208> Singular name, `PASCAL_CASE` instances and remove extra map. lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/having/HavingPredicates.java (line 29) <https://reviews.apache.org/r/43649/#comment181209> Same concern as the other enum classes. FYI: Have reviewed only a part of the whole code. Will do the rest later. - Rajat Khandelwal On Feb. 18, 2016, 5:44 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43649/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 5:44 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-271 > https://issues.apache.org/jira/browse/LENS-271 > > > Repository: lens > > > Description > ------- > > Changes for adding Druid driver in Lens > > > Diffs > ----- > > lens-driver-druid/pom.xml PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/ASTTraverserForDruid.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/ColumnSchema.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidDriver.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidDriverConfig.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidQuery.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/DruidQueryBuilder.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/client/DruidClient.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/client/DruidClientImpl.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/client/DruidResultSet.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/client/DruidResultSetTransformer.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/exceptions/DruidClientException.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/exceptions/DruidRewriteException.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/Aggregators.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/LogicalOperators.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/Predicates.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/having/HavingLogicalOperators.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/grammar/having/HavingPredicates.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/DruidCriteriaVisitor.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/DruidCriteriaVisitorFactory.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/DruidHavingVisitor.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/DruidHavingVisitorFactory.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/DruidVisitor.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/GroupByVisitor.java > PRE-CREATION > > lens-driver-druid/src/main/java/com/apache/lens/driver/druid/translator/TopNVisitor.java > PRE-CREATION > lens-driver-druid/src/main/resources/druiddriver-default.xml PRE-CREATION > > lens-driver-druid/src/test/java/org/apache/lens/driver/druid/DruidInitDriverTest.java > PRE-CREATION > > lens-driver-druid/src/test/java/org/apache/lens/driver/druid/MockClientDruid.java > PRE-CREATION > > lens-driver-druid/src/test/java/org/apache/lens/driver/druid/QueryTranslationTest.java > PRE-CREATION > > lens-driver-druid/src/test/java/org/apache/lens/driver/druid/ResultSetTransformationTest.java > PRE-CREATION > lens-driver-druid/src/test/resources/druiddriver-default.xml PRE-CREATION > lens-driver-druid/src/test/resources/hive-site.xml PRE-CREATION > lens-driver-druid/src/test/resources/invalid-queries.data PRE-CREATION > lens-driver-druid/src/test/resources/valid-queries.data PRE-CREATION > > lens-driver-es/src/main/java/org/apache/lens/driver/es/ASTTraverserForES.java > 07b157e > lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriverConfig.java > 8f293f5 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java > 38d91f9 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/InvalidQueryException.java > 20634af > > lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/Aggregations.java > f726fa5 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/LogicalOperators.java > b9cf000 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/grammar/Predicates.java > ec2af0f > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ASTCriteriaVisitor.java > b429424 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ASTVisitor.java > 77e774f > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/CriteriaVisitorFactory.java > 92ec10f > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/ESVisitor.java > 441f6d6 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESAggregateVisitor.java > e8f2cea > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESCriteriaVisitor.java > d1bf2a4 > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESCriteriaVisitorFactory.java > 04b773d > > lens-driver-es/src/main/java/org/apache/lens/driver/es/translator/impl/ESTermVisitor.java > 49aa0d4 > > lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java > 0b78639 > lens-examples/src/main/resources/cube-queries.sql 9f4a353 > lens-examples/src/main/resources/dimension-queries.sql a5f51d9 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/lib/ASTCriteriaVisitor.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/lib/ASTVisitor.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/lib/CriteriaVisitorFactory.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/lib/exception/InvalidQueryException.java > PRE-CREATION > pom.xml b3afa59 > src/site/apt/admin/druiddriver-config.apt PRE-CREATION > > Diff: https://reviews.apache.org/r/43649/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.883s] > [INFO] Lens .............................................. SUCCESS [3.355s] > [INFO] Lens API .......................................... SUCCESS [25.446s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.944s] > [INFO] Lens Cube ......................................... SUCCESS > [10:55.222s] > [INFO] Lens DB storage ................................... SUCCESS [20.357s] > [INFO] Lens Query Library ................................ SUCCESS [15.574s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.465s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.598s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.879s] > [INFO] Lens Driver for Druid ............................. SUCCESS [27.236s] > [INFO] Lens Server ....................................... SUCCESS > [10:03.541s] > [INFO] Lens client ....................................... SUCCESS [35.725s] > [INFO] Lens CLI .......................................... SUCCESS [50.380s] > [INFO] Lens Examples ..................................... SUCCESS [8.416s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.701s] > [INFO] Lens Distribution ................................. SUCCESS [8.340s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.841s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.998s] > [INFO] Lens Regression ................................... SUCCESS [14.291s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:58.174s > [INFO] Finished at: Wed Feb 17 11:13:45 UTC 2016 > [INFO] Final Memory: 199M/1276M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajitha R > >
