> On Feb. 24, 2016, 6:40 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 148 > > <https://reviews.apache.org/r/43929/diff/1/?file=1267012#file1267012line148> > > > > Can we still have this back and assert error for fetching again?
Second fetch is not resulting in error since the query takes some time to purge. Its returning blank result with zero rows since all rows have been read already (and we are not seeking to start of resultset anymore). I can check for zero rows (but i feel it may not make much sense in cli test cases) > On Feb. 24, 2016, 6:40 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 264 > > <https://reviews.apache.org/r/43929/diff/1/?file=1267012#file1267012line264> > > > > download result no more possible? Download result was checking for persistent result set. But this particular test case has InMemory result set. - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43929/#review120457 ----------------------------------------------------------- On Feb. 24, 2016, 3:23 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43929/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 3:23 a.m.) > > > Review request for lens. > > > Bugs: LENS-964 > https://issues.apache.org/jira/browse/LENS-964 > > > Repository: lens > > > Description > ------- > > Fixed Test cases for TestLensQueryCommands LENS-964 > - Fixed data provider > - Fixed individual test cases ( some were very old and assumed wrongly that > InMemory resultset can be read more than once, Also some changes in command > outputs were accounted for in the fix) > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 45555f45d69a70318b648da4630e23b598bca4e8 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 2de3cc1a415223c215fcfb41bea5c745185a1334 > > Diff: https://reviews.apache.org/r/43929/diff/ > > > Testing > ------- > > All 7 skipped test cases are running now > > -------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.lens.cli.TestLensQueryCommands > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 230.846 sec > - in org.apache.lens.cli.TestLensQueryCommands > > Results : > > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Puneet Gupta > >
