> On March 1, 2016, 11:26 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/main/resources/lens-client-default.xml, line 62
> > <https://reviews.apache.org/r/44171/diff/1/?file=1273934#file1273934line62>
> >
> > Should we say sync query or --async false instead of
> > EXECUTE_WITH_TIMEOUT?
Updated to "This property defines the timeout value when sync or --async false
option
is used to execute a query. The default value is 10 seconds"
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44171/#review121420
-----------------------------------------------------------
On Feb. 29, 2016, 2:19 p.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44171/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 2:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS_915
> https://issues.apache.org/jira/browse/LENS_915
>
>
> Repository: lens
>
>
> Description
> -------
>
> Incremental patch on top of LENS-964 (will re-submit once lens-964 is
> committed)
> - - Updated cli query execution to use EXECUTE_WITH_TIMEOUT
> - Added execute with timeout option to LensClient
> - Default timeout value is 10 secs ( can be configured by client)
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
> 0c1019804359420936911211b8467a9c8799723e
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
> b760dad2d6c095406b82da3b345f409d3e7bce2d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
> 007bf343555bb2cabcf83236728a196b82f633d4
>
> lens-cli/src/main/java/org/apache/lens/cli/config/LensCliConfigConstants.java
> PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
> 45555f45d69a70318b648da4630e23b598bca4e8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
> 2de3cc1a415223c215fcfb41bea5c745185a1334
> lens-client/src/main/java/org/apache/lens/client/LensClient.java
> ea0cd7630b155965d38bcb2db4c778339704164f
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java
> 33c26e136e3f69a508ad46de527f977cd3cbc131
> lens-client/src/main/resources/lens-client-default.xml
> e8dbd2c8a10b9a9a0bf9f409e5565357081b0791
>
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
> 699fa686f5feb865b029b4024e049520a22840da
> src/site/apt/user/client-config.apt
> 714db1853fe7e3d43c1a2b5756a40dd2e702b952
>
> Diff: https://reviews.apache.org/r/44171/diff/
>
>
> Testing
> -------
>
> 1. Tested new test cases
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.cli.TestLensQueryCommands
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 88.629 sec -
> in org.apache.lens.cli.TestLensQueryCommands
>
> 2. Tested CLI
> lens-shell>set lens.query.enable.persistent.resultset.indriver=false
> lens-shell>set lens.query.enable.persistent.resultset=true
> Set param succeeded
> lens-shell>cube select sample_dim.name, sample_dim2.name from sample_dim join
> sample_dim2 on sample_dim.d2id=sample_dim2.id ORDER BY sample_dim.name DESC
> 29 Feb 2016 13:08:58 [Spring Shell] INFO cliLogger - Executing query with
> timeout of 10000 milliseconds
> sample_dim.name sample_dim2.name
> Result available in memory, attaching here:
>
> third thirteen
> six sixteen
> second twelve
> fourth fourteen
> first eleven
> fifth fifteen
> eight eighteen
> 7 rows processed in (8) seconds.
> lens-shell>set lens.cli.query.execute.timeout.millis=1000
> Client side Set lens.cli.query.execute.timeout.millis=1000
> lens-shell>cube select sample_dim.name, sample_dim2.name from sample_dim join
> sample_dim2 on sample_dim.d2id=sample_dim2.id ORDER BY sample_dim.name DESC
> 29 Feb 2016 13:08:38 [Spring Shell] INFO cliLogger - Executing query with
> timeout of 1000 milliseconds
> 29 Feb 2016 13:08:47 [Spring Shell] INFO cliLogger - Couldn't complete query
> execution within timeout. Waiting for completion
> 29 Feb 2016 13:08:47 [Spring Shell] INFO cliLogger - Query handle:
> b071a81f-eea3-4da2-a0fd-451623dc23af
> 29 Feb 2016 13:08:47 [Spring Shell] INFO cliLogger - User query: 'cube
> select sample_dim.name, sample_dim2.name from sample_dim join sample_dim2 on
> sample_dim.d2id=sample_dim2.id ORDER BY sample_dim.name DESC' was submitted
> to hive/hive1
> 29 Feb 2016 13:08:47 [Spring Shell] INFO cliLogger - Driver query: 'SELECT
> ( sample_dim . name ), ( sample_dim2 . name ) FROM db2.local_dim_table
> sample_dim inner JOIN db2.local_dim_table2 sample_dim2 ON (( sample_dim .
> d2id ) = ( sample_dim2 . id )) AND ((sample_dim.dt = 'latest')) AND
> ((sample_dim2.dt = 'latest')) ORDER BY sample_dim . name desc' and Driver
> handle: OperationHandle [opType=EXECUTE_STATEMENT,
> getHandleIdentifier()=58a8efb4-08cf-4e3e-a279-87125bec9444]
> 29 Feb 2016 13:08:47 [Spring Shell] INFO cliLogger - Query Status:Progress:
> 1.0
> Status: SUCCESSFUL
> Status Message: Query is successful!
> Is Result Set Available: true
>
> sample_dim.name sample_dim2.name
> Results of query stored at :
> file:/tmp/lensreports/b071a81f-eea3-4da2-a0fd-451623dc23af.csv 7 rows
> processed in (9) seconds.
>
>
> lens-shell>set lens.query.enable.persistent.resultset.indriver=true
> lens-shell>set lens.query.enable.persistent.resultset=true
> lens-shell>cube select sample_dim.name, sample_dim2.name from sample_dim join
> sample_dim2 on sample_dim.d2id=sample_dim2.id ORDER BY sample_dim.name DESC
> 29 Feb 2016 13:06:37 [Spring Shell] INFO cliLogger - Executing query with
> timeout of 10000 milliseconds
> sample_dim.name sample_dim2.name
> Results of query stored at :
> file:/tmp/lensreports/ce0bcc86-bbb2-4a1c-b457-3eac18ca7cfb.csv 7 rows
> processed in (8) seconds.
> lens-shell>set lens.cli.query.execute.timeout.millis=1000
> Client side Set lens.cli.query.execute.timeout.millis=1000
> lens-shell>cube select sample_dim.name, sample_dim2.name from sample_dim join
> sample_dim2 on sample_dim.d2id=sample_dim2.id ORDER BY sample_dim.name DESC
> 29 Feb 2016 13:07:05 [Spring Shell] INFO cliLogger - Executing query with
> timeout of 1000 milliseconds
> 29 Feb 2016 13:07:15 [Spring Shell] INFO cliLogger - Couldn't complete query
> execution within timeout. Waiting for completion
> 29 Feb 2016 13:07:15 [Spring Shell] INFO cliLogger - Query handle:
> 1eb498e5-13c5-454f-a093-0fc08171d539
> 29 Feb 2016 13:07:15 [Spring Shell] INFO cliLogger - User query: 'cube
> select sample_dim.name, sample_dim2.name from sample_dim join sample_dim2 on
> sample_dim.d2id=sample_dim2.id ORDER BY sample_dim.name DESC' was submitted
> to hive/hive1
> 29 Feb 2016 13:07:15 [Spring Shell] INFO cliLogger - Driver query: 'INSERT
> OVERWRITE DIRECTORY
> "file:/tmp/lensreports/hdfsout/1eb498e5-13c5-454f-a093-0fc08171d539" SELECT
> ( sample_dim . name ), ( sample_dim2 . name ) FROM db2.local_dim_table
> sample_dim inner JOIN db2.local_dim_table2 sample_dim2 ON (( sample_dim .
> d2id ) = ( sample_dim2 . id )) AND ((sample_dim.dt = 'latest')) AND
> ((sample_dim2.dt = 'latest')) ORDER BY sample_dim . name desc ' and Driver
> handle: OperationHandle [opType=EXECUTE_STATEMENT,
> getHandleIdentifier()=e28bb36f-7243-4568-8b2f-3dfbbf34e6cf]
> sample_dim.name sample_dim2.name
> Results of query stored at :
> file:/tmp/lensreports/1eb498e5-13c5-454f-a093-0fc08171d539.csv 7 rows
> processed in (9) seconds.
>
>
> Thanks,
>
> Puneet Gupta
>
>
