> On March 7, 2016, 4:50 p.m., Raju Bairishetti wrote:
> > IMO, we should not increase the default value as it will increase the query 
> > execution time by poll interval. 
> > 
> > Initially, poll interval was set to 10 secs. Later we have decreased 
> > polling interval to 10 ms as it is affecting the query execution time.
> 
> Puneet Gupta wrote:
>     There are more details about how to manage query execution time on JIRA. 
> Please check once.

Raju, think of it in this way, even if the polling time is 10 seconds, the 
maximum extra time the user waits is 10 seconds. In the worst case, the query 
will complete just after a poll. Then the user has to wait 10 seconds before 
the next poll. Which I don't think is too much given that almost no query 
finishes in 10, even 20 seconds. 

Notice how I say it's *max* wait time, so assuming a uniform distribution, on 
average you're waiting for just 5 seconds, which is even less. 

Plus, with asynchronous notifications sent to the user immediately after 
completion, it's too much to poll so frequently. You're basically trying to 
build a push notification mechanism using http which I don't think http is 
suited for. 

If we do need such a functionality, we should consider things like websockets. 
http is not a swiss knife that can cater to all scenarios.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44438/#review122284
-----------------------------------------------------------


On March 7, 2016, 11:30 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44438/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 11:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-978
>     https://issues.apache.org/jira/browse/lens-978
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> The  poll interval is kept at 10 ms as of now . This causes excessive polling 
> on the server (as most clients do not set the property to an optimum value). 
> Propose to increase the value to 3-5 secs ( for specific use cases, users can 
> override this value if required)
> 
> 
> Changed the vale to 3.5 secs. Expect that the updated status is shown to the 
> user within 5 secs .
> 
> 
> Diffs
> -----
> 
>   lens-client/src/main/resources/lens-client-default.xml 
> e8dbd2c8a10b9a9a0bf9f409e5565357081b0791 
> 
> Diff: https://reviews.apache.org/r/44438/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

Reply via email to