----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44386/#review123114 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (lines 632 - 638) <https://reviews.apache.org/r/44386/#comment185278> Can we do something about the (almost) duplication of this function in `CandidateFact` and here? lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java (line 34) <https://reviews.apache.org/r/44386/#comment185286> Should we implement `updateFromString` here too and add the function to interface? lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java <https://reviews.apache.org/r/44386/#comment185287> Can you briefly explain what's happening to functions using these functions? It's difficult to figure out looking at the code. lens-cube/src/main/java/org/apache/lens/cube/parse/join/BridgeTableJoinContext.java (line 40) <https://reviews.apache.org/r/44386/#comment185294> Should we have tests of just this class too? Instead of testing this class with translating whole queries. - Rajat Khandelwal On March 4, 2016, 5:34 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44386/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 5:34 p.m.) > > > Review request for lens. > > > Bugs: LENS-788 > https://issues.apache.org/jira/browse/LENS-788 > > > Repository: lens > > > Description > ------- > > Changes include : > - Adds option to flatten early, if required. Default value is false. So, > aggregation are run over expressions if value is false. > - IN, NOT IN, = and != filters are converted to array_contains filters. Added > config to override for filter funciton to use. > - Did some refactoring to update fromString in QueryAST > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 82ca4f4 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > d96b567 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b8b6db9 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultAliasDecider.java > dadbfa0 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > a403e36 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 318c82a > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > d22287b > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8d6105f > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > b861bb6 > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 9c18b7e > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java 31680ca > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 63cb388 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java > b1a3b3f > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java > e14a898 > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/BridgeTableJoinContext.java > PRE-CREATION > lens-cube/src/main/resources/olap-query-conf.xml 1436cd1 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 42decc6 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java > e8ad8ff > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java cd20fef > src/site/apt/user/olap-cube.apt 4bed623 > src/site/apt/user/olap-query-conf.apt 6f84869 > > Diff: https://reviews.apache.org/r/44386/diff/ > > > Testing > ------- > > Tests passed except failing test wrt open session. > > Pending : Will add few more unit tests and update examples with bridge tables. > > > Thanks, > > Amareshwari Sriramadasu > >
