> On March 24, 2016, 3:45 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 24 > > <https://reviews.apache.org/r/45100/diff/2/?file=1311917#file1311917line24> > > > > Can we avoid expanding the imports? > > > > This is happening in many classes, please avoid doing these changes. > > Ajay Yadava wrote: > This is not a deliberate change, IntelliJ did it automatically for me. I > tried to look for the limits in checkstyle.xml for wilcard imports, but > couldn't find. What are the limits for static & normal imports after which it > should be a wild card import? > > Ajay Yadava wrote: > Will fix for all the cases where the wildcard imports are expanded but > need the numbers to turn imports to wildcard imports for new imports.
As per https://issues.apache.org/jira/browse/LENS-205?focusedCommentId=14282544&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14282544, it is 5 for imports and 3 for static imports. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45100/#review125195 ----------------------------------------------------------- On March 23, 2016, 2:02 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45100/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 2:02 p.m.) > > > Review request for lens. > > > Bugs: LENS-819 > https://issues.apache.org/jira/browse/LENS-819 > > > Repository: lens > > > Description > ------- > > Timeline of the fact returned should have structure instead of String. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/TimeLines.java PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 6457bce > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 9670d8f > lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > d0f2b57 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 02bbbbd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > c588dc7 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > 1642482 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 6c9eb7a > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java > a6cb8da > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 42decc6 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd83 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 684e2ed > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 3b091f5 > > Diff: https://reviews.apache.org/r/45100/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.545 > s] > [INFO] Lens ............................................... SUCCESS [ 2.307 > s] > [INFO] Lens API ........................................... SUCCESS [ 20.447 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 16.574 > s] > [INFO] Lens Cube .......................................... SUCCESS [20:52 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 38.239 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 11.201 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:40 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 51.661 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.836 > s] > [INFO] Lens Server ........................................ SUCCESS [12:42 > min] > [INFO] Lens client ........................................ SUCCESS [ 48.640 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:27 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 8.238 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.713 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.405 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:26 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 1.610 > s] > [INFO] Lens Regression .................................... SUCCESS [ 10.090 > s] > [INFO] Lens UI ............................................ SUCCESS [ 45.105 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 44:49 min > [INFO] Finished at: 2016-03-21T17:35:07+05:30 > [INFO] Final Memory: 145M/623M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Ajay Yadava > >
