> On March 28, 2016, 10:41 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java, > > line 61 > > <https://reviews.apache.org/r/45207/diff/4/?file=1316020#file1316020line61> > > > > <p>Should we move all syncronization to QueryContext by making > > updateDriverStatus() synchronized</p> > > <p>or reduce the sync scope to FailureContext?</p>
Yes. We should do this. > On March 28, 2016, 10:41 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 389 > > <https://reviews.apache.org/r/45207/diff/4/?file=1316022#file1316022line389> > > > > Should we also log the execption as Warning incase further retiries are > > pending and as an Error when retries are exhausted ? Yes. Will add. > On March 28, 2016, 10:41 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 392 > > <https://reviews.apache.org/r/45207/diff/4/?file=1316022#file1316022line392> > > > > Should we log the next update time ? Will add it to the above log. > On March 28, 2016, 10:41 a.m., Puneet Gupta wrote: > > lens-server/src/test/resources/lens-site.xml, line 197 > > <https://reviews.apache.org/r/45207/diff/4/?file=1316030#file1316030line197> > > > > Is this value intentionally different from default value ? Yes. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45207/#review125617 ----------------------------------------------------------- On March 28, 2016, 7:33 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45207/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 7:33 a.m.) > > > Review request for lens. > > > Bugs: LENS-893 > https://issues.apache.org/jira/browse/LENS-893 > > > Repository: lens > > > Description > ------- > > - Adds next update to happen with increasing wait times upon transient > failures. Adds a max delay to cap the increasing time as well. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 52a7ccc > > lens-server-api/src/main/java/org/apache/lens/server/api/common/ExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 8ee8a3b > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > c3b6d26 > > lens-server-api/src/test/java/org/apache/lens/server/api/common/TestExponentialBackOffRetryHandler.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 7f39da1 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 5af45ed > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 90c25e4 > lens-server/src/main/resources/lensserver-default.xml 6bb66d9 > lens-server/src/test/resources/lens-site.xml b5b3220 > src/site/apt/admin/config.apt 6df9796 > src/site/apt/user/client-config.apt 714db18 > > Diff: https://reviews.apache.org/r/45207/diff/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Amareshwari Sriramadasu > >
