> On Feb. 18, 2016, 11:30 a.m., Rajat Khandelwal wrote: > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java, > > line 48 > > <https://reviews.apache.org/r/41974/diff/3/?file=1230817#file1230817line48> > > > > Please rename the class as the name `Helper` suggests it's a utility > > class, but it's not. > > > > A Utility class is something that has just static functions.
will take up as a part of code reform once all regression tests are moved. > On Feb. 18, 2016, 11:30 a.m., Rajat Khandelwal wrote: > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java, > > lines 78-80 > > <https://reviews.apache.org/r/41974/diff/3/?file=1230817#file1230817line78> > > > > There are multiple instances in your code that do > > > > ``` > > Response response = this.exec(something); > > T result = response.readEntity(new GenericType<T>(){}); > > return result > > ``` > > > > This can be abstracted out in a single function, resulting in single > > line here > > > > ``` > > return this.execNew(something) > > ``` There are many places where its asserting on Response status. Also it reduces just 1 line so keepign it same. - Archana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41974/#review119602 ----------------------------------------------------------- On Feb. 3, 2016, 8:08 a.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41974/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 8:08 a.m.) > > > Review request for lens and Arshad Matin. > > > Repository: lens > > > Description > ------- > > Currently response string is converted to respective class using JAXB. This > will be changed to directly read using GenericType. > > > Diffs > ----- > > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > 37fb703 > > Diff: https://reviews.apache.org/r/41974/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [6.617s] > [INFO] Lens .............................................. SUCCESS [11.539s] > [INFO] Lens API .......................................... SUCCESS [40.755s] > [INFO] Lens API for server and extensions ................ SUCCESS [35.881s] > [INFO] Lens Cube ......................................... SUCCESS [1:04.407s] > [INFO] Lens DB storage ................................... SUCCESS [14.099s] > [INFO] Lens Query Library ................................ SUCCESS [19.862s] > [INFO] Lens Hive Driver .................................. SUCCESS [26.200s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.567s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [22.494s] > [INFO] Lens Server ....................................... SUCCESS [1:17.241s] > [INFO] Lens client ....................................... SUCCESS [27.042s] > [INFO] Lens CLI .......................................... SUCCESS [28.721s] > [INFO] Lens Examples ..................................... SUCCESS [15.957s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.248s] > [INFO] Lens Distribution ................................. SUCCESS [13.863s] > [INFO] Lens ML Lib ....................................... SUCCESS [31.349s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [9.308s] > [INFO] Lens Regression ................................... SUCCESS [27.231s] > [INFO] Lens UI ........................................... SUCCESS [2:20.430s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 10:45.309s > [INFO] Finished at: Wed Jan 06 14:52:30 IST 2016 > [INFO] Final Memory: 178M/919M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
