----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45748/#review128074 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java (line 101) <https://reviews.apache.org/r/45748/#comment191468> public scope required? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java (line 105) <https://reviews.apache.org/r/45748/#comment191467> Why are we doing concat for values? We can avoid, it can simply hold the value. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java (line 110) <https://reviews.apache.org/r/45748/#comment191469> public scope required? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java (line 130) <https://reviews.apache.org/r/45748/#comment191466> Can we add @Getter for tags instead of this method? - Amareshwari Sriramadasu On April 5, 2016, 2:32 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45748/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 2:32 p.m.) > > > Review request for lens. > > > Bugs: LENS-39 > https://issues.apache.org/jira/browse/LENS-39 > > > Repository: lens > > > Description > ------- > > Tags are key value pairs associated with a cube column eg : category, > visible-on-ui and etc. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f221a6d > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 5a353df > lens-cli/src/test/resources/sample-cube.xml 9bcf177 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > bd4ae57 > lens-cube/src/main/java/org/apache/lens/cube/metadata/ColumnMeasure.java > 5fda721 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java > 77024c0 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimAttribute.java > 26c24de > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMeasure.java > d5fc0e7 > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > da87e31 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > cd4862c > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 399d5a7 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java > 9a1c44b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 18575f6 > lens-examples/src/main/resources/sample-cube.xml 4046e82 > > lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java > b884368 > lens-examples/src/test/resources/yaml/sales-cube.yaml 935e3f6 > lens-examples/src/test/resources/yaml/sample-cube.yaml 3f2ffc0 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 6571dae > > Diff: https://reviews.apache.org/r/45748/diff/ > > > Testing > ------- > > Added new unit test and updated existing ones. mvn clean install runs fine. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.902s] > [INFO] Lens .............................................. SUCCESS [3.307s] > [INFO] Lens API .......................................... SUCCESS [30.097s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.037s] > [INFO] Lens Cube ......................................... SUCCESS > [18:07.196s] > [INFO] Lens DB storage ................................... SUCCESS [20.254s] > [INFO] Lens Query Library ................................ SUCCESS [16.667s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:14.702s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.039s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.117s] > [INFO] Lens Server ....................................... SUCCESS > [17:10.246s] > [INFO] Lens client ....................................... SUCCESS [34.699s] > [INFO] Lens CLI .......................................... SUCCESS [3:18.955s] > [INFO] Lens Examples ..................................... SUCCESS [12.618s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.761s] > [INFO] Lens Distribution ................................. SUCCESS [9.560s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:27.646s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.171s] > [INFO] Lens Regression ................................... SUCCESS [13.508s] > [INFO] Lens UI ........................................... SUCCESS [42.649s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 47:44.019s > [INFO] Finished at: Tue Apr 05 14:13:50 UTC 2016 > [INFO] Final Memory: 210M/2441M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
