----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46251/#review129076 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (lines 459 - 467) <https://reviews.apache.org/r/46251/#comment192531> similar code is present in `execute` method, can we abstract out to reduce code duplication? lens-client/src/main/java/org/apache/lens/client/LensStatement.java (lines 384 - 390) <https://reviews.apache.org/r/46251/#comment192532> this template is also used multiple times (reading response, parsing a type conditionally and throwing exception otherwise). Maybe we can think about abstracting this out too. Not opening an issue for this, just putting out an idea. lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (lines 692 - 694) <https://reviews.apache.org/r/46251/#comment192533> Should be similar to execute code: return LensAPIResult.composedOf(null, requestId, result); } catch (LensException e) { e.buildLensErrorResponse(errorCollection, null, requestId); throw e; } - Rajat Khandelwal On April 15, 2016, 9:29 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46251/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 9:29 a.m.) > > > Review request for lens. > > > Bugs: LENS-984 > https://issues.apache.org/jira/browse/LENS-984 > > > Repository: lens > > > Description > ------- > > Response type of prepared query execution REST end point > /queryapi/preparedqueries/{prepareHandle} should be wrapped in LensAPIResult > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > af05951 > lens-client/src/main/java/org/apache/lens/client/LensClient.java 9626820 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java f06bcd1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > a043550 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > df13ba2 > > Diff: https://reviews.apache.org/r/46251/diff/ > > > Testing > ------- > > Exhaustive unit tests already existed for the method, ensured that they are > passing after the change as well. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.165 > s] > [INFO] Lens ............................................... SUCCESS [ 1.700 > s] > [INFO] Lens API ........................................... SUCCESS [ 16.217 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 12.800 > s] > [INFO] Lens Cube .......................................... SUCCESS [26:42 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 27.125 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 8.728 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:10 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 39.038 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 9.669 > s] > [INFO] Lens Server ........................................ SUCCESS [11:58 > min] > [INFO] Lens client ........................................ SUCCESS [ 35.527 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:08 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 6.252 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.470 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 6.464 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:09 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 1.656 > s] > [INFO] Lens Regression .................................... SUCCESS [ 8.170 > s] > [INFO] Lens UI ............................................ SUCCESS [ 1.895 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 47:07 min > [INFO] Finished at: 2016-04-15T09:02:42+05:30 > [INFO] Final Memory: 171M/931M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Ajay Yadava > >
