-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46430/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-730
    https://issues.apache.org/jira/browse/LENS-730


Repository: lens


Description
-------

Fixes following alias issues with multi fact queries and expressions

- When alias of a selected expression is a column name used in a Expression 
column. For ex : select col1 as f1, expr1 as f2 from cube ; expr1 = complex(f2)
- When different expressions (functions) are around a column and no alias is 
passed for them : For : func1(dim1), func2(dim1)
- When alias is in the form of expression. For ex: select msr1 as `sum(msr1)` 
from cube


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
fd7036a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
75aa3f4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
04c3c45 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 379e873 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
fec5d51 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java 
e8905c1 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
6ee45d8 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
fa07b67 

Diff: https://reviews.apache.org/r/46430/diff/


Testing
-------

All cube tests pass.


Thanks,

Amareshwari Sriramadasu

Reply via email to