> On April 15, 2016, 12:07 p.m., Rajat Khandelwal wrote: > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/HiveDriverConfig.java, > > lines 28-30 > > <https://reviews.apache.org/r/46206/diff/1/?file=1344494#file1344494line28> > > > > These constants are already present in > > `MaxConcurrentDriverQueriesConstraintFactory`. In case the key changes > > later on, we shouldn't need to change in two places.
Retaining it to keep all driver related configs at same place but changed to read value from MaxConcurrentDriverQueriesConstraintFactory. > On April 15, 2016, 12:07 p.m., Rajat Khandelwal wrote: > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java, > > line 79 > > <https://reviews.apache.org/r/46206/diff/1/?file=1344495#file1344495line79> > > > > why this change? Filter value should be passed like 'first\'s'. Extra backslash is to escape '\' in String. > On April 15, 2016, 12:07 p.m., Rajat Khandelwal wrote: > > lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java, > > lines 163-164 > > <https://reviews.apache.org/r/46206/diff/1/?file=1344499#file1344499line163> > > > > Probably `LensServerAPITestUtil.getLensConf` can be useful. LensServerAPITestUtil is in src/test so unable to import. > On April 15, 2016, 12:07 p.m., Rajat Khandelwal wrote: > > lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java, > > line 297 > > <https://reviews.apache.org/r/46206/diff/1/?file=1344499#file1344499line297> > > > > Should there be asserts on the size of list too? Size of the result set is asserted inside validateInMemoryResultSet function - Archana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46206/#review129103 ----------------------------------------------------------- On April 20, 2016, 12:59 p.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46206/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 12:59 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Adding prepared and query API tests > > > Diffs > ----- > > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/HiveDriverConfig.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java > eb889c4 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionConfig.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > 5035ce8 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > 64268a6 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46206/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.624s] > [INFO] Lens .............................................. SUCCESS [4.030s] > [INFO] Lens API .......................................... SUCCESS [33.199s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.770s] > [INFO] Lens Cube ......................................... SUCCESS > [11:51.946s] > [INFO] Lens DB storage ................................... SUCCESS [21.493s] > [INFO] Lens Query Library ................................ SUCCESS [16.262s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:17.615s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.777s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.531s] > [INFO] Lens Server ....................................... SUCCESS > [17:22.143s] > [INFO] Lens client ....................................... SUCCESS [36.441s] > [INFO] Lens CLI .......................................... SUCCESS [3:15.608s] > [INFO] Lens Examples ..................................... SUCCESS [11.098s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.774s] > [INFO] Lens Distribution ................................. SUCCESS [9.812s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:23.875s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s] > [INFO] Lens Regression ................................... SUCCESS [14.017s] > [INFO] Lens UI ........................................... SUCCESS [46.735s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 41:50.603s > [INFO] Finished at: Thu Apr 14 12:23:13 UTC 2016 > [INFO] Final Memory: 213M/2598M > [INFO] > ------------------------------------------------------------------------ > > > File Attachments > ---------------- > > LENS-1004_1.patch > > https://reviews.apache.org/media/uploaded/files/2016/04/20/0fdf50f2-727c-492c-ad5d-28b47b9e3dac__LENS-1004_1.patch > > > Thanks, > > Archana H > >
