-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46552/
-----------------------------------------------------------
(Updated April 25, 2016, 1:19 p.m.)
Review request for lens.
Bugs: lens-1013
https://issues.apache.org/jira/browse/lens-1013
Repository: lens
Description
-------
as of now DriverQueryHook has a preLaunch() method which is called just before
launching the query .
We should also have an option to interact with hook on postSelect() which will
be called once query has been accepted by lens server and appropriate driver
has been selected for it.
Also as of now, the preLaunch() is called by individual driver. This should be
moved to server and drivers should not manage this operation.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
aa37dcc
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
ba3f3d5
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
4f18c24
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
eef4464
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
81a9552
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
883ad9d
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
ecac6be
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
69295d9
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
a5475e4
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
b568ffb
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
94b79d0
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
2505ef4
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
42bd4ab
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
df13ba2
lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 6362473
lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml d5be96e
Diff: https://reviews.apache.org/r/46552/diff/
Testing
-------
mvn test -Dtest=org.apache.lens.server.query.TestQueryService#testExecuteAsync
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.959 sec -
in org.apache.lens.server.query.TestQueryService
Results :
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
Logs from MockDriverQueryHook
-----
22 Apr 2016 02:32:11 f5f0df2e-b8c5-4b10-b9a9-d714f3be6caf
[grizzly-http-server-3] INFO
org.apache.lens.server.api.driver.NoOpDriverQueryHook - Post select for foo,
user query: select ID, IDSTR from TEST_TABLE, driver hive/hive1, driver query:
select ID, IDSTR from TEST_TABLE
22 Apr 2016 02:32:43 4d3c9dc6-2abf-432a-aa94-acb937c1b457 [QuerySubmitter] INFO
org.apache.lens.server.api.driver.NoOpDriverQueryHook - Pre launch for foo,
user query: select ID, IDSTR from TEST_TABLE, driver hive/hive1, driver query:
select ID, IDSTR from TEST_TABLE
Pending
------
Will try to update server restart test case and MockQueryDriverHook to use
AbstractQueryContext#updateConf(Map)
Thanks,
Puneet Gupta
