----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46938/#review131646 -----------------------------------------------------------
lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java (line 36) <https://reviews.apache.org/r/46938/#comment195675> `JDBCDriverConfConstants.ConnectionPoolProperties.JDBC_POOL_MAX_SIZE.getConfigKey()` lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java (line 46) <https://reviews.apache.org/r/46938/#comment195676> Instead of string replace, can we use `%s` in SLEEP_QUERY_TIME and `String.fromat(SLEEP_QUERY_TIME, time)` here? lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java (line 57) <https://reviews.apache.org/r/46938/#comment195677> Can we reduce/remove sleep? lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java (line 302) <https://reviews.apache.org/r/46938/#comment195678> rename to `getResultSetResponse` lens-regression/src/main/java/org/apache/lens/regression/util/Util.java (line 68) <https://reviews.apache.org/r/46938/#comment195679> remove the line lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java (line 468) <https://reviews.apache.org/r/46938/#comment195680> Why is sleep added? lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java (line 76) <https://reviews.apache.org/r/46938/#comment195681> 1. `grep -i lens`? 2. What if multiple lens server processes are running? `ps -ef | grep -i lens | grep ... | grep .. | awk ... | xargs -L1 kill -9` solves for that. lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java (line 360) <https://reviews.apache.org/r/46938/#comment195682> Comment can be more descriptive. - Rajat Khandelwal On May 4, 2016, 1:05 p.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46938/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 1:05 p.m.) > > > Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > Adding server configuration tests to regression > > > Diffs > ----- > > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java > 5a2df11 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java > 869a96b > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java > 2f8b9c0 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > 2b4a750 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > 4918882 > > lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java > ea36858 > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 6c3d234 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java > 60cf26c > > lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java > bf40c74 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java > e16b220 > > lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java > 8aabe2d > > lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java > 62dd0ba > > lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46938/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.981s] > [INFO] Lens .............................................. SUCCESS [3.316s] > [INFO] Lens API .......................................... SUCCESS [19.095s] > [INFO] Lens API for server and extensions ................ SUCCESS [15.684s] > [INFO] Lens Cube ......................................... SUCCESS [6:48.240s] > [INFO] Lens DB storage ................................... SUCCESS [15.062s] > [INFO] Lens Query Library ................................ SUCCESS [12.688s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:25.271s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [31.631s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [12.114s] > [INFO] Lens Server ....................................... SUCCESS > [13:32.537s] > [INFO] Lens client ....................................... SUCCESS [1:42.565s] > [INFO] Lens CLI .......................................... SUCCESS [2:07.638s] > [INFO] Lens Examples ..................................... SUCCESS [8.887s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.678s] > [INFO] Lens Distribution ................................. SUCCESS [9.547s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:06.594s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.511s] > [INFO] Lens Regression ................................... SUCCESS [9.505s] > [INFO] Lens UI ........................................... SUCCESS [54.924s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 31:00.347s > [INFO] Finished at: Tue May 03 14:59:52 UTC 2016 > [INFO] Final Memory: 182M/2644M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
