> On May 4, 2016, 11:50 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServices.java, lines > > 313-314 > > <https://reviews.apache.org/r/46968/diff/1/?file=1370653#file1370653line313> > > > > Why is this removed?
This is moved to init. > On May 4, 2016, 11:50 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServices.java, line 353 > > <https://reviews.apache.org/r/46968/diff/1/?file=1370653#file1370653line353> > > > > Should we catch Throwable? Exception should be ok. Didn't want to catch Errors like OutOfMemoryError in which case the server state itself is not stable. This should be handled else where. > On May 4, 2016, 11:50 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServices.java, line 420 > > <https://reviews.apache.org/r/46968/diff/1/?file=1370653#file1370653line420> > > > > typo in comment Will update this - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46968/#review131654 ----------------------------------------------------------- On May 4, 2016, 10:17 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46968/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 10:17 a.m.) > > > Review request for lens. > > > Bugs: lens-1029 > https://issues.apache.org/jira/browse/lens-1029 > > > Repository: lens > > > Description > ------- > > - Service level persistence isolation. If persisting one service fails, other > services should still be persisted. > - Persistence thread to run only in case SERVER_RESTART_ENABLED = true > - Moved form Timer to ScheduledExecutorService. Graceful shutdown of > ScheduledExecutorService enabled to allow a running persistence task, if any, > to finish > - Catching Exception instead of IOException to prevent the persistence task > from dying. > - using writeObject() instead of writeInt() for automatic null handling. > > > Diffs > ----- > > > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java > 8c06621 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e00 > > Diff: https://reviews.apache.org/r/46968/diff/ > > > Testing > ------- > > Relying on exiting test case to check persistence TestServerRestart. > > **mvn test -Dtest=org.apache.lens.server.TestServerRestart#testQueryService** > Running org.apache.lens.server.TestServerRestart > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 206.408 sec - > in org.apache.lens.server.TestServerRestart > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > > **mvn test > -Dtest=org.apache.lens.server.TestServerRestart#testSessionRestart** > Running org.apache.lens.server.TestServerRestart > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.711 sec - > in org.apache.lens.server.TestServerRestart > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > > **Apart from this** > - Did some local testing for making sure null Integers are persisted using > writeObject and can be read back as well. > - Did some local testing to check graceful shutdown of > ScheduledExecutorService > Don't think we need a test cases for above two cince its supported out of box > by java > > > Thanks, > > Puneet Gupta > >
