> On May 3, 2016, 4:59 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java, > > line 581 > > <https://reviews.apache.org/r/46884/diff/1/?file=1368232#file1368232line581> > > > > Should it be in HQLParser? > > Amareshwari Sriramadasu wrote: > HQLParser already has one. Since we want to call it in cube.metadata > package - copied here.
Moved all usgaes to MetastoreUtil.copyAST. Moved the method because cube.metadata should not depend on cube.parse. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46884/#review131455 ----------------------------------------------------------- On May 9, 2016, 7:22 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46884/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 7:22 a.m.) > > > Review request for lens. > > > Bugs: LENS-614 > https://issues.apache.org/jira/browse/LENS-614 > > > Repository: lens > > > Description > ------- > > -Fixed handling of single column expressions in ColumnResolver, > AggregateResolver and AliasReplacer > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > 1c9d6d2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 006c4cb > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 1593a54 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > e629731 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 3f724b6 > lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java > 58a1d4d > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > c3d15d0 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 9ee94d3 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 02571ee > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 73e6221 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > d54e8b9 > > Diff: https://reviews.apache.org/r/46884/diff/ > > > Testing > ------- > > All cube tests pass. > > [INFO] Surefire report directory: > /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > Tests run: 390, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 383.748 sec > - in TestSuite > > Results : > > Tests run: 390, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Amareshwari Sriramadasu > >
