----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47121/#review132365 -----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 214) <https://reviews.apache.org/r/47121/#comment196546> should we have only one public close*() method ? Two methods can be confusing for end user. If we need to return APIResult, we can not adhere to Closeable Interface - Puneet Gupta On May 9, 2016, 3:18 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47121/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 3:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-1010 > https://issues.apache.org/jira/browse/LENS-1010 > > > Repository: lens > > > Description > ------- > > This would allow users to use lens client in try-with-resources clause > without worrying about closing manually. > > https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 43da691aff52bc108f99033fac2e8e068ae1c216 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 49518662eb17c1fd24deb26ddd46a36c8826bc5b > > Diff: https://reviews.apache.org/r/47121/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
