----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47180/#review132418 -----------------------------------------------------------
Partial review (Session test resview pending) lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 88) <https://reviews.apache.org/r/47180/#comment196606> Should we update the method name ? lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 109) <https://reviews.apache.org/r/47180/#comment196607> Can we move this statement down, before checking for persistnet result. lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 113) <https://reviews.apache.org/r/47180/#comment196608> Can we assert actual number of rows and also columns lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 124) <https://reviews.apache.org/r/47180/#comment196609> We can remove this test as only client side object is being checked . lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 163) <https://reviews.apache.org/r/47180/#comment196612> This will be Persistent result. We can remove/merge this test with testQueryResultStreaming lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (line 164) <https://reviews.apache.org/r/47180/#comment196611> Should we use fail(message) instead. lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java (lines 198 - 203) <https://reviews.apache.org/r/47180/#comment196613> Should we test Assert.assertNull(inmemoryResult) instead ? - Puneet Gupta On May 10, 2016, 12:25 p.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47180/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 12:25 p.m.) > > > Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > Streaming and other session related tests > > > Diffs > ----- > > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java > da13715 > > lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java > PRE-CREATION > lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47180/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.561s] > [INFO] Lens .............................................. SUCCESS [2.827s] > [INFO] Lens API .......................................... SUCCESS [19.983s] > [INFO] Lens API for server and extensions ................ SUCCESS [17.356s] > [INFO] Lens Cube ......................................... SUCCESS > [13:42.634s] > [INFO] Lens DB storage ................................... SUCCESS [16.138s] > [INFO] Lens Query Library ................................ SUCCESS [12.865s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:21.882s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [33.708s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.681s] > [INFO] Lens Server ....................................... SUCCESS [8:25.801s] > [INFO] Lens client ....................................... SUCCESS [1:28.082s] > [INFO] Lens CLI .......................................... SUCCESS [1:18.041s] > [INFO] Lens Examples ..................................... SUCCESS [8.313s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.614s] > [INFO] Lens Distribution ................................. SUCCESS [9.532s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:07.238s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.319s] > [INFO] Lens Regression ................................... SUCCESS [10.384s] > [INFO] Lens UI ........................................... SUCCESS [46.063s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:45.897s > [INFO] Finished at: Tue May 10 11:23:35 UTC 2016 > [INFO] Final Memory: 197M/2756M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
