----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46890/#review132814 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 766) <https://reviews.apache.org/r/46890/#comment197067> subquery should be 'select id from countrydim cubecountry where ..." Seems actual table is missed and only alias is put in from clause. Also, is dimtable has snapshot dumps, we need to add latest time filter additionally. - Amareshwari Sriramadasu On May 11, 2016, 1:57 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46890/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 1:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-1028 > https://issues.apache.org/jira/browse/LENS-1028 > > > Repository: lens > > > Description > ------- > > Changes include dim filters to rewrite as fact filers for star joins. > e.g. > where dim.name in ('x', 'y') > becomes > where fact.dimid in (select dim.id from dim where dim.name in ('x','y')) > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 3f724b6 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > a57292c > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 6f016f2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java > 0697e78 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 7c14be7 > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 9674f73 > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 4d6ce9e > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java f064dcb > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java > 8b24f70 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > f4ef5ca > src/site/apt/user/olap-query-conf.apt 6372fb1 > > Diff: https://reviews.apache.org/r/46890/diff/ > > > Testing > ------- > > Added unit tests. mvn clean install works fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.453s] > [INFO] Lens .............................................. SUCCESS [3.003s] > [INFO] Lens API .......................................... SUCCESS [21.845s] > [INFO] Lens API for server and extensions ................ SUCCESS [15.399s] > [INFO] Lens Cube ......................................... SUCCESS [6:54.821s] > [INFO] Lens DB storage ................................... SUCCESS [14.147s] > [INFO] Lens Query Library ................................ SUCCESS [11.250s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:24.637s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.131s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [12.729s] > [INFO] Lens Server ....................................... SUCCESS > [14:10.700s] > [INFO] Lens client ....................................... SUCCESS [1:25.019s] > [INFO] Lens CLI .......................................... SUCCESS [2:13.299s] > [INFO] Lens Examples ..................................... SUCCESS [8.918s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.709s] > [INFO] Lens Distribution ................................. SUCCESS [8.732s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:10.374s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.440s] > [INFO] Lens Regression ................................... SUCCESS [10.038s] > [INFO] Lens UI ........................................... SUCCESS [44.771s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 31:23.276s > [INFO] Finished at: Mon May 09 15:04:12 UTC 2016 > [INFO] Final Memory: 163M/2144M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
