-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47820/
-----------------------------------------------------------
(Updated May 25, 2016, 9:43 a.m.)
Review request for lens.
Changes
-------
updated test result.
Bugs: LENS-1155
https://issues.apache.org/jira/browse/LENS-1155
Repository: lens
Description
-------
Issue :
When user launching InMemory Queries, the connection is released back to pool
only after result set is read completely or after query is purged. For InMemory
Queries (not persisted by lens server), the query state is changed to
SUCCESSFUL even before connection is released.This causes connection pool to
throw error for new queries whenever JDBC driver is running at almost full load.
Fix :
Added a new constraint at JDBC driver to check max allowed connections. At any
given time to launch a query the number of query context objects held by driver
should be less than connection pool max size.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
044a19c
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java
PRE-CREATION
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraintFactory.java
PRE-CREATION
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml b5b6164
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
67f6c1f
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java
a0691a5
Diff: https://reviews.apache.org/r/47820/diff/
Testing (updated)
-------
mvn clean install.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.568s]
[INFO] Lens .............................................. SUCCESS [3.851s]
[INFO] Lens API .......................................... SUCCESS [21.238s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.135s]
[INFO] Lens Cube ......................................... SUCCESS [14:05.321s]
[INFO] Lens DB storage ................................... SUCCESS [17.297s]
[INFO] Lens Query Library ................................ SUCCESS [14.356s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:22.104s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.757s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [22.355s]
[INFO] Lens Server ....................................... SUCCESS [9:17.492s]
[INFO] Lens client ....................................... SUCCESS [1:31.286s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.286s]
[INFO] Lens Examples ..................................... SUCCESS [7.670s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.624s]
[INFO] Lens Distribution ................................. SUCCESS [9.221s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:07.127s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.984s]
[INFO] Lens Regression ................................... SUCCESS [11.468s]
[INFO] Lens UI ........................................... SUCCESS [25.865s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:54.713s
[INFO] Finished at: Wed May 25 09:26:53 UTC 2016
[INFO] Final Memory: 201M/2506M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
