----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46437/#review135415 -----------------------------------------------------------
contrib/clients/pom.xml (line 26) <https://reviews.apache.org/r/46437/#comment200426> Seems pointing to wrong parent module here. Can we set parent to lens-contrib? contrib/clients/python/lens/client/main.py (line 39) <https://reviews.apache.org/r/46437/#comment200436> can we add *defalt* db as default value here? conf.get('lens.client.dbname', "default") contrib/clients/python/pom.xml (line 27) <https://reviews.apache.org/r/46437/#comment200427> Seems pointing to wrong parent module here. Can we set parent to **lens-contrib-clients**? contrib/pom.xml (line 31) <https://reviews.apache.org/r/46437/#comment200435> Can we add contrib module under **modules** section in main pom.xml? - Raju Bairishetti On May 9, 2016, 2:36 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46437/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 2:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-1011 > https://issues.apache.org/jira/browse/LENS-1011 > > > Repository: lens > > > Description > ------- > > I have been working on a python client for lens. After multiple rounds of > polishing, it's in a stable state now. It still doesn't have all the > functionality parallel to the java client, but would like to add that to the > repo so that people can use and (maybe) contribute. Added in contrib > directory. Want to figure out how to integrate with mvn for running tests. > > > Diffs > ----- > > contrib/clients/pom.xml PRE-CREATION > contrib/clients/python/.gitignore PRE-CREATION > contrib/clients/python/README PRE-CREATION > contrib/clients/python/lens/__init__.py PRE-CREATION > contrib/clients/python/lens/client/__init__.py PRE-CREATION > contrib/clients/python/lens/client/log.py PRE-CREATION > contrib/clients/python/lens/client/main.py PRE-CREATION > contrib/clients/python/lens/client/models.py PRE-CREATION > contrib/clients/python/lens/client/query.py PRE-CREATION > contrib/clients/python/lens/client/utils.py PRE-CREATION > contrib/clients/python/pom.xml PRE-CREATION > contrib/clients/python/setup.cfg PRE-CREATION > contrib/clients/python/setup.py PRE-CREATION > contrib/clients/python/test/test_lensclient.py PRE-CREATION > contrib/clients/python/tox.ini PRE-CREATION > contrib/pom.xml PRE-CREATION > pom.xml cb213bbb32b17b3ddd2bbb7ff37424495f0a96d7 > > Diff: https://reviews.apache.org/r/46437/diff/ > > > Testing > ------- > > Added integration tests. Passing on both python 2.7 and python 3.5 -- the two > major versions in use right now. > > http://showterm.io/342007fee7bb18fb82c86 > > > Thanks, > > Rajat Khandelwal > >
