----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47593/#review136222 -----------------------------------------------------------
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 51) <https://reviews.apache.org/r/47593/#comment201246> Worried about the total run time of the test cases in this class. Can you share the run times ? lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 236 - 238) <https://reviews.apache.org/r/47593/#comment201240> We are passing only low and verylow configration. Do we need to pass high and normal also ? lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 267) <https://reviews.apache.org/r/47593/#comment201243> Priority should never be null. Should we fail the test case if it is ? lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 268) <https://reviews.apache.org/r/47593/#comment201244> Is COST_20 will be NORMAL priority ? If yes we need to count normals also. lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 275 - 277) <https://reviews.apache.org/r/47593/#comment201245> It will be better to have a default case where we can fail the test case incase we get an unexpected value for priority. lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 292 - 295) <https://reviews.apache.org/r/47593/#comment201247> Should we remove this check ? queued and running list is empty already . - Puneet Gupta On June 2, 2016, 8:40 a.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47593/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 8:40 a.m.) > > > Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > Throttling tests to regression > > > Diffs > ----- > > lens-regression/pom.xml b9bee97 > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 1a538da > > lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java > e588c1b > > lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java > 4da4c3a > > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47593/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s] > [INFO] Lens .............................................. SUCCESS [3.553s] > [INFO] Lens API .......................................... SUCCESS [20.758s] > [INFO] Lens API for server and extensions ................ SUCCESS [16.842s] > [INFO] Lens Cube ......................................... SUCCESS > [14:01.494s] > [INFO] Lens DB storage ................................... SUCCESS [17.028s] > [INFO] Lens Query Library ................................ SUCCESS [18.060s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s] > [INFO] Lens Server ....................................... SUCCESS [8:49.961s] > [INFO] Lens client ....................................... SUCCESS [1:29.573s] > [INFO] Lens CLI .......................................... SUCCESS [1:18.608s] > [INFO] Lens Examples ..................................... SUCCESS [7.455s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s] > [INFO] Lens Distribution ................................. SUCCESS [9.060s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s] > [INFO] Lens Regression ................................... SUCCESS [11.454s] > [INFO] Lens UI ........................................... SUCCESS [27.047s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 31:41.125s > [INFO] Finished at: Thu May 19 11:53:17 UTC 2016 > [INFO] Final Memory: 186M/2279M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
