----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48317/#review136611 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1052) <https://reviews.apache.org/r/48317/#comment201714> Whats the purpose of this check if we are setting this only in finally clause? - Amareshwari Sriramadasu On June 8, 2016, 7:19 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48317/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 7:19 a.m.) > > > Review request for lens. > > > Bugs: LENS-1164 > https://issues.apache.org/jira/browse/LENS-1164 > > > Repository: lens > > > Description > ------- > > Inmemory queries are not picked from waiting queue even after successful > completion of query. With this fix waiting queries will also be processed. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 8fe02aa > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > 8493d85 > > Diff: https://reviews.apache.org/r/48317/diff/ > > > Testing > ------- > > Added unit test.Reproduced the scenario mentioned in ticket LENS-1164 in > local system and it works fine with attached patch. > > mvn clean install : > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.501s] > [INFO] Lens .............................................. SUCCESS [3.360s] > [INFO] Lens API .......................................... SUCCESS [22.328s] > [INFO] Lens API for server and extensions ................ SUCCESS [17.760s] > [INFO] Lens Cube ......................................... SUCCESS > [14:41.982s] > [INFO] Lens DB storage ................................... SUCCESS [17.157s] > [INFO] Lens Query Library ................................ SUCCESS [12.136s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:22.201s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.023s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.724s] > [INFO] Lens Server ....................................... SUCCESS [9:12.028s] > [INFO] Lens client ....................................... SUCCESS [1:29.543s] > [INFO] Lens CLI .......................................... SUCCESS [1:18.083s] > [INFO] Lens Examples ..................................... SUCCESS [9.460s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.758s] > [INFO] Lens Distribution ................................. SUCCESS [11.536s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:18.650s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.198s] > [INFO] Lens Regression ................................... SUCCESS [11.726s] > [INFO] Lens UI ........................................... SUCCESS [33.234s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 32:44.083s > [INFO] Finished at: Tue Jun 07 05:34:19 UTC 2016 > [INFO] Final Memory: 190M/2057M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
