----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48543/#review137208 -----------------------------------------------------------
+1 - Raju Bairishetti On June 10, 2016, 11:42 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48543/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 11:42 a.m.) > > > Review request for lens. > > > Bugs: LENS-1183 > https://issues.apache.org/jira/browse/LENS-1183 > > > Repository: lens > > > Description > ------- > > 1. In LensSessionImpl if acquireCount.incrementAndGet() >1 , no need to > execute the proceeding 3 lines > > {code} > public synchronized void acquire(boolean userAccess) { > super.acquire(userAccess); > acquireCount.incrementAndGet(); > // Update thread's class loader with current DBs class loader > ClassLoader classLoader = getClassLoader(getCurrentDatabase()); > Thread.currentThread().setContextClassLoader(classLoader); > SessionState.getSessionConf().setClassLoader(classLoader); > setActive(); > } > > {code} > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 40124ee91e085863b57de443d22abcbcddfa2b73 > > Diff: https://reviews.apache.org/r/48543/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
