----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49096/#review139223 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 1127) <https://reviews.apache.org/r/49096/#comment204362> I agree with Amareshwari. Let's use the lens server db directly. lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java (line 45) <https://reviews.apache.org/r/49096/#comment204363> Why is this moved to `lens-server-api`? All client facing classes are commonly present in `lens-api` module. lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java (line 51) <https://reviews.apache.org/r/49096/#comment204364> Non-zero return in case of error? lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java (line 347) <https://reviews.apache.org/r/49096/#comment204365> Let's follow half open ranges. `[startTime, endTime)` lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java (line 20) <https://reviews.apache.org/r/49096/#comment204366> `ToXMLString.toString(XJob)` should be sufficient. No need to write a new method. lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java (line 34) <https://reviews.apache.org/r/49096/#comment204367> `ToXMLString.valueOf(String)` should work. - Rajat Khandelwal On June 22, 2016, 9:34 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49096/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 9:34 p.m.) > > > Review request for lens. > > > Bugs: LENS-988 > https://issues.apache.org/jira/browse/LENS-988 > > > Repository: lens > > > Description > ------- > > Stores the Job definitions and job instance definitions. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > 4a2baba > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java > 92260b5 > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > f19d3f0 > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java > 9146cf0 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0a81f7b > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 2bcf0d6 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > f575bc8 > > lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > 838b9b8 > > Diff: https://reviews.apache.org/r/49096/diff/ > > > Testing > ------- > > To be updated. > > > Thanks, > > Lavkesh Lahngir > >
