> On June 23, 2016, 2:52 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 183 > > <https://reviews.apache.org/r/48951/diff/3/?file=1427317#file1427317line183> > > > > throws HiveException can be removed ?
No. All the partition and timeline operations still have `HiveException`. > On June 23, 2016, 2:52 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 1389 > > <https://reviews.apache.org/r/48951/diff/3/?file=1427317#file1427317line1389> > > > > Who are the callers with throwException false? `getAll*`. e.g. `getAllCubes`, `getAllDimensions`, ... > On June 23, 2016, 2:52 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 1490 > > <https://reviews.apache.org/r/48951/diff/3/?file=1427317#file1427317line1490> > > > > Why is this removed? - applies to all segmenation methods. Not anymore. Now `getAll*` methods are implemented in the following way: foreach getAllHiveTables: getTableWithType(table, type, false) ... > On June 23, 2016, 2:52 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 1447 > > <https://reviews.apache.org/r/48951/diff/3/?file=1427317#file1427317line1447> > > > > change it to LensException ? Had found this as a natural balance point between `HiveException` and `LensException`. Changing this was problematic somehow. Anyway, I'm thinking let's do these changes incrementally. I'll upload a version with this change sometime, We can take that up either in this or separately. But I'm hoping to get a +1 for the changes done so far. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48951/#review139225 ----------------------------------------------------------- On June 22, 2016, 1:26 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48951/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 1:26 p.m.) > > > Review request for lens. > > > Bugs: LENS-1187 > https://issues.apache.org/jira/browse/LENS-1187 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 0d7b345a50f941a064eb968d57309d4c88eed508 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > e49b58b113d4bd0aa34bcbdb057469223ab9f736 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > de8f23bd288dfffca052084c9578d041a1ea66de > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > cc8929fb87fe6bb130a62f7b9dd067c1ada7eca5 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > 012081aa57a7a6b5fad84bddef04b970989b9af4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 31d2d2c3bc8517d7634ebf7698a44a981faf4546 > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > 36ee9d46f220ded8125a5d4d0cf8ebbdf3b690c2 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 7dceee146a7517485ff43a3f8da365d07d56efe2 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > f84f2e0f8ae726f750879f69126c536720718bfa > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 86db011b57846c45a3d94a29a2ab1cfa35ef2d49 > lens-server/src/main/java/org/apache/lens/server/BaseApp.java > 07f683707e04e6bfc91ed59a89c9036562b9b072 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 0b4720e49fff9437d08cbfdc256a8790d198ec71 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > f6f2f3647ecebafea13390f0ab544205f8c54368 > > lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java > 658fcb2415a4c924dbfd05cf2e3f229170a3df51 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 595520e5182556ce14781bf7ffabd58c105e68a0 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 57b18362b4e6749694c048f10dbacc06d7255db7 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 1b76ea5f9f52f56b65d41a5cf63c44f6133a8c8b > > Diff: https://reviews.apache.org/r/48951/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
