----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49154/#review142196 -----------------------------------------------------------
contrib/clients/python/README.md (line 15) <https://reviews.apache.org/r/49154/#comment207760> With all the special methods defined it makes the code unintuitive. You don't know whether to treat 'queries' as a method or as a datastructure. It will be nice to change to something like below: client.get_queries() :returns a list of queries client.get_query() : returns details using query handle. Explicit functions corresponding to various rest endpoints will ensure more readability and intuitive client api. - Ajay Yadava On July 14, 2016, 5:52 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49154/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 5:52 a.m.) > > > Review request for lens. > > > Bugs: LENS-1202 > https://issues.apache.org/jira/browse/LENS-1202 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > contrib/clients/python/README.md 00525fffe0c84421ca60cdb23bc9ed7f42963736 > contrib/clients/python/lens/client/main.py > dc604979415160ae17c9fcdcef3f258d5e38af38 > contrib/clients/python/lens/client/models.py > 7451fe92b29531f2bdb9219239c6f2b597fe7aac > contrib/clients/python/lens/client/query.py > 88ce719890e8bf1c08410284583db14bb23c568c > contrib/clients/python/lens/client/session.py PRE-CREATION > contrib/clients/python/test/test_lensclient.py > d49c55bdca924eabd0b61f540372db4c3f3e695e > > Diff: https://reviews.apache.org/r/49154/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
