> On July 20, 2016, 12:03 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java, > > line 134 > > <https://reviews.apache.org/r/50133/diff/2/?file=1447184#file1447184line134> > > > > Removing default values would cause users to always pass the values for > > these params. they will basically become mandatory params.
It won't become mandatory. http://stackoverflow.com/a/13979349/459384 - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50133/#review142910 ----------------------------------------------------------- On July 19, 2016, 3:15 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50133/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 3:15 p.m.) > > > Review request for lens. > > > Bugs: LENS-996 > https://issues.apache.org/jira/browse/LENS-996 > > > Repository: lens > > > Description > ------- > > 1. fromDate and endDate should also take human readable dates. > DateUtil.resolveDate can be used. > 2. the status filter should be case-insensitive. > 3. (maybe) the user filter and status filter can take multiple comma > separated values and return the union in the result. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > b82cd95b5633b91e03cf1df8ac2602cb7798099a > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > d10ad099b7220545802a3fcc7fd6e32a1c5b272a > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2de098d5f16b3fc7fffff6c5cfa78c6b9a694c1d > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 803bbe3db982dc74ba2a1bdba94fc68879dcd351 > > lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java > 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 > > Diff: https://reviews.apache.org/r/50133/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
