> On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote: > > lens-server/enunciate.xml, line 22 > > <https://reviews.apache.org/r/50579/diff/1/?file=1456802#file1456802line22> > > > > Why is this falcon?
My bad. I had updated enunciate for falcon as well. Copy-paste mistake. Will fix. > On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote: > > lens-server/enunciate.xml, line 29 > > <https://reviews.apache.org/r/50579/diff/1/?file=1456802#file1456802line29> > > > > Dont we require custom handling for FormDataParam anymore ? > > > > Can you validate generated doc is fine and confirm? No, we dont require it anymore in the latest version. Reference - https://github.com/stoicflame/enunciate/issues/85 > On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote: > > lens-server/pom.xml, line 417 > > <https://reviews.apache.org/r/50579/diff/1/?file=1456803#file1456803line417> > > > > Why are we saying source and target as 1.7? Will it work with 1.8 as > > well? Yes, It will work with both 1.7 and 1.8 if I set it to 1.7. If I set it to 1.8, It will only work with 1.8. Should I change it to 1.8 ?? > On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote: > > pom.xml, line 1870 > > <https://reviews.apache.org/r/50579/diff/1/?file=1456804#file1456804line1870> > > > > We should change or remove jdk version here. Yeah, we can remove this. The enunciate works just fine without the activation tag. It seems unnecessary. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50579/#review144053 ----------------------------------------------------------- On July 28, 2016, 7:03 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50579/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 7:03 p.m.) > > > Review request for lens. > > > Bugs: LENS-952 > https://issues.apache.org/jira/browse/LENS-952 > > > Repository: lens > > > Description > ------- > > Bump up enunciate version to work with java 8 > > > Diffs > ----- > > lens-server/enunciate.xml 7013f13 > lens-server/pom.xml 2294b2a > pom.xml 176fb0e > > Diff: https://reviews.apache.org/r/50579/diff/ > > > Testing > ------- > > Yes. > Ran "mvn clean install -Penunciate" successfully. > > > Thanks, > > Deepak Barr > >
