-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50782/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1190
https://issues.apache.org/jira/browse/LENS-1190
Repository: lens
Description
-------
User can enable FINISHED notifictaion for a query by setting
lens.query.http.notification.type.FINISHED = true and by setting http end
points in lens.query.http.notification.urls
QueryEventHttpNotifier is the base class for all QueryEvent HTTP Notifications.
As of now only finished notifictaion is implemented QueryEndHttpNotifier (can
extend the base framework to add other useful notifictaions for users like
QueryPositionChage, Launched, ProgressUpdate, etc)
Default information(eventtype, eventtime, lensQuery) will be propaggeted in
notifictaions. We can extend and add extra info wherever required (like say
result for successful queries if its small enough). @see
org.apache.lens.server.query.QueryEventHttpNotifier#updateExtraEventDetails
Note: Keeping a single configration "lens.query.http.notification.urls" for
query notifictaion end points. All notifuctaion types for a single query will
be delivered to same set of end points. If there is a use case, we can have
notifictaion type sepcific end points per query.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
72e2b61
lens-server/src/main/java/org/apache/lens/server/query/QueryEndHttpNotifier.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
84dcecd
lens-server/src/main/resources/lensserver-default.xml e9525fd
lens-server/src/main/resources/lenssession-default.xml 62fca51
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
9f40a01
src/site/apt/admin/config.apt db859e6
src/site/apt/admin/session-config.apt fc6916f
Diff: https://reviews.apache.org/r/50782/diff/
Testing
-------
mvn test
-Dtest=org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion
--------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 105.946 sec -
in org.apache.lens.server.query.TestQueryService
Results :
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Puneet Gupta
