----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51177/#review146167 -----------------------------------------------------------
Fix it, then Ship it! Other changes look fine to me. lens-server/src/test/java/org/apache/lens/server/TestServerMode.java (line 81) <https://reviews.apache.org/r/51177/#comment212555> Is this session ever closed? If not, you might want to close them properly. Same with @BeforeClass as well. - Amareshwari Sriramadasu On Aug. 17, 2016, 2:12 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51177/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 2:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-1241 > https://issues.apache.org/jira/browse/LENS-1241 > > > Repository: lens > > > Description > ------- > > Session creation and drop; table creation, loading and drop moved to > beforeClass > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > e09180f > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > caf968a > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > 56c67fb > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > be1326f > > lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java > c20ddf8 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > 50baf5f > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 5196c9b > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryResultPurger.java > c498ada > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > a1ecaa6 > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > cb0d858 > > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > a8b58b2 > > lens-server/src/test/java/org/apache/lens/server/rewrite/TestUserQueryToCubeQueryRewriter.java > 38f8d71 > > lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java > 02f371c > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 3aa3163 > > lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java > 1656f4e > > Diff: https://reviews.apache.org/r/51177/diff/ > > > Testing > ------- > > mvn clean install runs fine. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.064s] > [INFO] Lens .............................................. SUCCESS [5.084s] > [INFO] Lens API .......................................... SUCCESS [33.241s] > [INFO] Lens API for server and extensions ................ SUCCESS [44.540s] > [INFO] Lens Cube ......................................... SUCCESS > [16:16.839s] > [INFO] Lens DB storage ................................... SUCCESS [17.957s] > [INFO] Lens Query Library ................................ SUCCESS [13.814s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:29.576s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [43.593s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [22.435s] > [INFO] Lens Server ....................................... SUCCESS > [14:15.372s] > [INFO] Lens client ....................................... SUCCESS [1:32.571s] > [INFO] Lens CLI .......................................... SUCCESS [1:31.938s] > [INFO] Lens Examples ..................................... SUCCESS [9.518s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.709s] > [INFO] Lens Distribution ................................. SUCCESS [9.927s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:18.968s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.708s] > [INFO] Lens Regression ................................... SUCCESS [14.800s] > [INFO] Lens UI ........................................... SUCCESS [37.262s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 40:44.037s > [INFO] Finished at: Wed Aug 17 13:03:45 UTC 2016 > [INFO] Final Memory: 200M/2421M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
