----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51552/#review147626 -----------------------------------------------------------
lens-ui/app/components/QueryOperationsComponent.js (line 59) <https://reviews.apache.org/r/51552/#comment214831> fromDate should be now, and endDate to now.day - 2 days, no ? Also, I feel no time filter should be passed for running or queued queries. Lets pass time filter only for completed queries. lens-ui/app/components/QueryResultsComponent.js (line 82) <https://reviews.apache.org/r/51552/#comment214829> commented code? lens-ui/app/components/QueryResultsComponent.js (line 136) <https://reviews.apache.org/r/51552/#comment214830> Seems some debugging code here - Amareshwari Sriramadasu On Aug. 31, 2016, 7:14 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51552/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2016, 7:14 a.m.) > > > Review request for lens. > > > Bugs: LENS-1303 > https://issues.apache.org/jira/browse/LENS-1303 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-ui/app/actions/AdhocQueryActions.js > 38f2794a443c7814a20a9662efb06c9b431e764b > lens-ui/app/adapters/AdhocQueryAdapter.js > a54274fbf1e83d06ca7175eb9c3905662731067a > lens-ui/app/components/CubeSchemaComponent.js > 9c23b9fd3cd8a6ae87802ce9a07f2267ef76f8f7 > lens-ui/app/components/QueryOperationsComponent.js > e4cc1e7304092ea6fcce28d6ed3d895f5061d982 > lens-ui/app/components/QueryPreviewComponent.js > a29f2d8ad71c59cbc7ba22ac7e95512399acc16f > lens-ui/app/components/QueryResultsComponent.js > 01f0e30415bd2f2a7d2acfdddf51c388fc683ed8 > lens-ui/app/constants/AdhocQueryConstants.js > 7eceb6fec6ca64497bbc78973ecb818e2bd89190 > lens-ui/app/stores/AdhocQueryStore.js > d8891c26e5003b09c512db9352841a654fdde27a > > Diff: https://reviews.apache.org/r/51552/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
