-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52117/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 9:16 a.m.)


Review request for lens.


Changes
-------

Addressed review comments.


Bugs: LENS-1334
    https://issues.apache.org/jira/browse/LENS-1334


Repository: lens


Description
-------

Currently full outer join queries are written like below
...from A full outer join B full outer join C on A.col = B.col and A.col = C.col
instead it should be rewritten as
...from A full outer join B  on a.col = b.col full outer join C on B.col = C.col


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
7fbcd7e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
6fb027a 

Diff: https://reviews.apache.org/r/52117/diff/


Testing
-------

Fixed test case 
TestBaseCubeQueries.testMultiFactQueryInvolvingThreeFactTables.All lens-cube 
test cases passed.

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Running TestSuite

Tests run: 405, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,088.137 sec 
- in TestSuite

Results :

Tests run: 405, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:26.226s
[INFO] Finished at: Wed Sep 21 17:13:00 IST 2016
[INFO] Final Memory: 66M/1537M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Reply via email to