----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52337/#review150694 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 28, 2016, 7:04 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52337/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 7:04 a.m.) > > > Review request for lens. > > > Bugs: lens-1324 > https://issues.apache.org/jira/browse/lens-1324 > > > Repository: lens > > > Description > ------- > > Currently we have two hooks > 1. preLaunch > 2. postDriverSelection > > Need to add some hooks that can hook into rewrite and estimate flow also. > 1.preRewrite, postRewrite > 2.preEstimate,postEstimate > > NoOpDriverQueryHook will have default empty implementation for these new > methods . > > Also added void setDriver(LensDriver driver) in Driver Hook to pass the > driver information. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 84d9933 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 3bf5e8f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > 03079e2 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java > da125bd > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java > 8cd03cb > > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java > 792508b > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 168b3cc > > lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java > 0c4a3f0 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 0bb106e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > f755508 > > Diff: https://reviews.apache.org/r/52337/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.lens.server.query.TestQueryService > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.906 sec - > in org.apache.lens.server.query.TestQueryService > > Results : > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 04:41 min > [INFO] Finished at: 2016-09-28T11:47:07+05:30 > [INFO] Final Memory: 133M/1482M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Puneet Gupta > >
