> On Sept. 26, 2016, 1:19 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 32 > > <https://reviews.apache.org/r/52259/diff/2/?file=1510054#file1510054line32> > > > > What interval are the keys in the map spaced over? > > > > Perhaps we need an UpdatePeriod argument? > > > > Also, do keep in mind that end date should be exclusive. > > > > And, if we are passing start, end and UpdatePeriod, it might be better > > to use `org.apache.lens.cube.metadata.TimePartitionRange` > > Narayan Periwal wrote: > Keys are spaced over hourly intervals, this is fixed. > Sure, will take care of this fact that end date is exclusive.
I would not recommend using org.apache.lens.cube.metadata.TimePartitionRange, as those are not public classes. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150396 ----------------------------------------------------------- On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52259/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 1:03 p.m.) > > > Review request for lens. > > > Bugs: LENS-1340 > https://issues.apache.org/jira/browse/LENS-1340 > > > Repository: lens > > > Description > ------- > > The data completeness API will take the factTag, startDate, endDate and > measure's list as input. > It will return the completeness percentage for each of the measures for the > given factTag and time range. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52259/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >