----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52687/#review152292 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java <https://reviews.apache.org/r/52687/#comment221268> Can we add another test where parsing of expression fails and asserts for message are present? - Amareshwari Sriramadasu On Oct. 10, 2016, 12:48 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52687/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 12:48 p.m.) > > > Review request for lens. > > > Bugs: LENS-1355 > https://issues.apache.org/jira/browse/LENS-1355 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > c522061f3428c62dbf5a2ed8ec6b192d480f3fa6 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 6d53d00f43c149a010c2f49aef44ace2a89c9348 > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 26ae1e72ce3a8d04d4a9b5cd1cdf8dc237eae712 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 1976248c066b518bb8de517631050878cf96c5e5 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 2619cb0800f5d22ac1bce52cb50136c879789de2 > > Diff: https://reviews.apache.org/r/52687/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
