----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52683/#review152459 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 12, 2016, 12:05 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52683/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 12:05 p.m.) > > > Review request for lens. > > > Bugs: LENS-1354 > https://issues.apache.org/jira/browse/LENS-1354 > > > Repository: lens > > > Description > ------- > > Bunch of changes here > > 1. The cube with 5000+ measures and 5000+ dim attributes isn't getting > created and is timing out in one of the HashMap.get operations. Changed 5000 > to 1000 and it's fine now. Tried multiple times. > 2. dimtable is partitioned by dt and dimension doesn't have "dt" as time > dimension. So while creating dimtable, it tries to cache the latest value, > where key is the time dimension and value is the partition value. Since time > dimension is null, it goes to look for a partition with filter > `null='latest'`, which fails, since `null` isn't a partition key for the > dimtable. Not sure why it's not failing in master though. These are the > changes in statedim and zipdim > 3. The chanes in CubeTestSetup: For countrytable_partitioned, dumpperiods are > set to <HOURLY>, and time part column isn't specified. Which shouldn't be > allowed. Again, not sure why it's not failing on master. > > > Diffs > ----- > > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2ac187318cbc52bd0e49cc8e7065236c4e0 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > f7f8af22dd07c4798b0856e6ddc0b0fc16d4177a > > Diff: https://reviews.apache.org/r/52683/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
