-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review152845
-----------------------------------------------------------




lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 (line 38)
<https://reviews.apache.org/r/52924/#comment222011>

    Can we add a  simple test case for this? To keep it simple we can use 
mutiple usser hooks in the chain and test pre rewrite.



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 (line 28)
<https://reviews.apache.org/r/52924/#comment222007>

    Should we add class level documentation expaling when this will be useful ?



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 (lines 31 - 32)
<https://reviews.apache.org/r/52924/#comment222009>

    Can we use a Set instead for faster search/conatins opeartion ?


- Puneet Gupta


On Oct. 17, 2016, 10:25 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 10:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1359
>     https://issues.apache.org/jira/browse/LENS-1359
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  8f30aa06ab234cedb53acb17544210ba4190ab53 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
>  69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  f8a9ee07d8c8b737a41de339ab44ca7752c90748 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  146223942d05cfd952599297144e2a6bc02df273 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
>  f70979abf7c44d3b4ed3588628de5a7517adfa81 
>   src/site/apt/admin/hivedriver-config.apt 
> b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 
> 
> Diff: https://reviews.apache.org/r/52924/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to