----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52982/#review153674 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java (line 35) <https://reviews.apache.org/r/52982/#comment223099> Name is a bit ambiguous regarding the functionality. Can we rename it to reflect that it's checking `contains` in error message? lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java (line 45) <https://reviews.apache.org/r/52982/#comment223100> We should handle for cases when either of the above two are null. lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java (line 37) <https://reviews.apache.org/r/52982/#comment223101> The arguments are int, long, long lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestConfiguredPolicyDecider.java (lines 54 - 56) <https://reviews.apache.org/r/52982/#comment223102> This seems like a problem in `ImmediateRetryHandler`. Instead of ``` @Override public boolean hasExhaustedRetries(FC failContext) { return ++retriesDone > retries; } ``` It should be ``` @Override public boolean hasExhaustedRetries(FC failContext) { failContext.getFailCount() > retries; } ``` Can you make the change? - Rajat Khandelwal On Oct. 20, 2016, 6:27 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52982/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 6:27 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > If any one of the configured messages are found then the retry will happen > > > Diffs > ----- > > lens-driver-hive/src/main/resources/hivedriver-default.xml > f5fd3bb20b9d6b82292c4483d860ea14c8104c5c > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml > 89726c4f352a6e57dd81b6ae84cca221a345ebb6 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6ca126f0a3535974352adf97e7a495838f > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java > 01da25d12393615cfb4e4680c97c7445df0bbe83 > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java > c1c0126ae9ac89cb4a50fe5948075094f10cb518 > > lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestConfiguredPolicyDecider.java > PRE-CREATION > src/site/apt/admin/hivedriver-config.apt > b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 > src/site/apt/admin/jdbcdriver-config.apt > c64d6ee0d4ac1dff9fadd02826e67a8e4839d99f > > Diff: https://reviews.apache.org/r/52982/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
