> On Oct. 26, 2016, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, > > line 169 > > <https://reviews.apache.org/r/51964/diff/4/?file=1545070#file1545070line169> > > > > not sure how its corresponding local jar file is added to classloader. > > If hdfs jar is getting added, it wont work. > > > > might have to pass the corresponding local jar as the location value > > for ResourceEntry. > > Sushil Mohanty wrote: > In case of base dir is hdfs, first copying the files to local directory > and setting local as base directory and respective jar files are picked from > here. > > if > (resTopDirPath.getFileSystem(getHiveConf()).getScheme().equals("hdfs")) { > localResTopDir = > getHiveConf().get(LensConfConstants.DATABASE_LOCAL_RESOURCE_DIR, > LensConfConstants.DEFAULT_LOCAL_DATABASE_RESOURCE_DIR); > downloadJarFilesFromHDFS(resTopDir, localResTopDir); > resTopDir = localResTopDir; > }
We cannot change resTopDir which is hdfs to a local path. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review153851 ----------------------------------------------------------- On Nov. 3, 2016, 5:31 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51964/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 5:31 p.m.) > > > Review request for lens. > > > Bugs: LENS-317 > https://issues.apache.org/jira/browse/LENS-317 > > > Repository: lens > > > Description > ------- > > Server side api call to update database jar without restarting lens server. > More details can be found in LENS-317. > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > c6ae02b > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > 7fc8438 > lens-cli/src/test/resources/schema/jars/test_db_resource.jar PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java e936798 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > bb15b23 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 8f9db2a > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 20ec686 > lens-server/pom.xml d24dc1e > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > 511e4cf > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 21e2a62 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 34c901c > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 63eea63 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > e48eab4 > lens-server/src/main/resources/lensserver-default.xml a00048b > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > 67cee57 > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java > 2bc3712 > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseService.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml d96659f > pom.xml 29c59d3 > > Diff: https://reviews.apache.org/r/51964/diff/ > > > Testing > ------- > > mvn clean install. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.302s] > [INFO] Lens .............................................. SUCCESS [7.286s] > [INFO] Lens API .......................................... SUCCESS [31.546s] > [INFO] Lens API for server and extensions ................ SUCCESS [25.681s] > [INFO] Lens Cube ......................................... SUCCESS > [17:55.255s] > [INFO] Lens DB storage ................................... SUCCESS [25.650s] > [INFO] Lens Query Library ................................ SUCCESS [21.646s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:11.167s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [1:03.464s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [54.798s] > [INFO] Lens Server ....................................... SUCCESS > [18:19.588s] > [INFO] Lens client ....................................... SUCCESS [2:02.590s] > [INFO] Lens CLI .......................................... SUCCESS [1:54.985s] > [INFO] Lens Examples ..................................... SUCCESS [13.790s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [2.061s] > [INFO] Lens Distribution ................................. SUCCESS [24.869s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:54.426s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [11.053s] > [INFO] Lens Regression ................................... SUCCESS [20.677s] > [INFO] Lens UI ........................................... SUCCESS [19.454s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 49:44.002s > [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 > [INFO] Final Memory: 178M/2490M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
