----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53835/#review156196 -----------------------------------------------------------
Ship it! Ship It! - Puneet Gupta On Nov. 17, 2016, 4:20 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53835/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 4:20 a.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1377 > https://issues.apache.org/jira/browse/LENS-1377 > > > Repository: lens > > > Description > ------- > > Finding measure covering set is including facts which cover all measures in > other fact combinations as well, which can be removed. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 510bd8c > > Diff: https://reviews.apache.org/r/53835/diff/ > > > Testing > ------- > > All cube tests passed : > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,135.432 > sec - in TestSuite > > Results : > > Tests run: 418, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Amareshwari Sriramadasu > >