----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54057/#review161186 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (lines 191 - 192) <https://reviews.apache.org/r/54057/#comment232999> Should we make these datastructures local so that we don't need to reset them? lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 355) <https://reviews.apache.org/r/54057/#comment233000> Should we call this getNonReachableReferenceFields ? lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 395) <https://reviews.apache.org/r/54057/#comment232603> Should we call this getORCreateAndGetDeNormCtx ? lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java (line 284) <https://reviews.apache.org/r/54057/#comment232998> Can we add method level comments whereever possible. - Puneet Gupta On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54057/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2016, 6:16 a.m.) > > > Review request for lens. > > > Bugs: LENS-1378 > https://issues.apache.org/jira/browse/LENS-1378 > > > Repository: lens > > > Description > ------- > > Fix is to add DenormalizationContext for each expression instead of being > part of main CubeQueryContext > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > e7fc557 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > e83ae76 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 40ed387 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 60dacdb > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java > 11eb8f7 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java > 89b50f5 > lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 41ea83d > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > f2bb485 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 6430ed1 > tools/conf/server/logback.xml 63ab23c > > Diff: https://reviews.apache.org/r/54057/diff/ > > > Testing > ------- > > All cube tests passed > > > Thanks, > > Amareshwari Sriramadasu > >
