[
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857558#comment-15857558
]
Amareshwari Sriramadasu commented on LENS-1381:
-----------------------------------------------
Comments on the code in branch lens-1381 :
# TODO statements in FactPartition class does not look relevant. Can be removed.
# Many TODO statements in various classes should be removed or acted upon.
# Javadoc on Candidate interface needs update.
# I see lots of code throwing 'throw new LensException("Not a
StorageCandidate!!");' - we need to understand if it will be hit in any code
flow.
# Why is storateTable renamed to storageName in CandidateDim?
# ' String getStorageName();' in CandidateTable interface should be renamed to
getStorageTableName().
# I feel, with CandidateTableResolver checkForQueriedColumns should happen
before populating storage candidates
# Populating of factDimMap in CubeQueryContext.toHQL() might need changes
# DenormalizationResolver and ExpressionResolver needs merge with master
# What does position in QueriedPhraseContext signify? The queried phrase can be
in any clause - select, where or group by and etc. What does the position say
here?
> Support Fact to Fact Union
> --------------------------
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
> Issue Type: New Feature
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
>
> Currently Lens supports Union-ing data across different storages in a single
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
